Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #4223: remove hls_acodec and hls_vcodec config. #4225

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

suzp1984
Copy link
Contributor

@suzp1984 suzp1984 commented Nov 8, 2024

try to fix #4223

The hls.hls_acodec and hls.hls_vcodec seems meanless, can be removed.

How to verify?

  1. objs/srs -c conf/hls.conf

  2. publish three kinds of streams: pure audio stream, pure video stream, audio&video stream.
    ffmpeg -re -i doc/source.flv -c copy -vn -f flv rtmp://localhost/live/audio
    ffmpeg -re -i doc/source.flv -c copy -an -f flv rtmp://localhost/live/video
    ffmpeg -re -i doc/source.flv -c copy -f flv rtmp://localhost/live/av

  3. use ffprobe to detect the hls streams.
    ffprobe http://localhost:8080/live/audio.m3u8
    ffprobe http://localhost:8080/live/video.m3u8
    ffprobe http://localhost:8080/live/av.m3u8

@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Nov 8, 2024
@duiniuluantanqin
Copy link
Member

maybe you need check it with Safari on macOS again.

@suzp1984
Copy link
Contributor Author

maybe you need check it with Safari on macOS again.

checked on safari, access http://localhost:8080/players/srs_player.html?schema=http
play the three hls streams mentioned in step 3:

http://localhost:8080/live/audio.m3u8
http://localhost:8080/live/video.m3u8
http://localhost:8080/live/av.m3u8

everything seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When pushing a stream without audio, the HLS stream contains abnormal audio encoding information.
3 participants