Skip to content

feat: add RemoveTag engine method #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add RemoveTag engine method #130

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4afb26
feat: add RemoveTag engine method
Nov 18, 2025
5c93d92
fix: remove value assertion
Nov 18, 2025
aedae6b
fix: rename engine variable in test
jaime-amate Nov 18, 2025
a79eab4
fix: remove not needed tag registration in test
jaime-amate Nov 18, 2025
0922fc8
chore: add description for RemoveTag method
jaime-amate Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,3 +173,7 @@ func (e *Engine) ParseTemplateAndCache(source []byte, path string, line int) (*T
func (e *Engine) SetAutoEscapeReplacer(replacer render.Replacer) {
e.cfg.SetAutoEscapeReplacer(replacer)
}

func (e *Engine) RemoveTag(name string) {
e.cfg.RemoveTag(name)
}
16 changes: 16 additions & 0 deletions engine_examples_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,3 +305,19 @@ func TestIssue63_UnicodeVariableNames(t *testing.T) {
require.Equal(t, "content", string(result))
})
}

func TestRemoveTag(t *testing.T) {
Copy link
Owner

@osteele osteele Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a test, this should go in engine_test.go. Or rename it to ExampleEngine_RemoveTag as a testable example.

engine := NewEngine()
engine.RegisterTag("echo", func(c render.Context) (string, error) {
return c.TagArgs(), nil
})
source := `{% echo hello world %}`

_, err := engine.ParseAndRenderString(source, emptyBindings)
require.NoError(t, err)

engine.RemoveTag("echo")

_, err = engine.ParseAndRenderString(source, emptyBindings)
require.Error(t, err)
}
Comment on lines +309 to +323
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test only verifies removing a custom tag (echo), but the PR description specifically mentions removing standard tags like {% include %} to get parse errors. Consider adding a test case that removes a standard tag to ensure this use case works as intended.

Example:

t.Run("RemoveStandardTag", func(t *testing.T) {
    engine := NewEngine()
    source := `{% if true %}test{% endif %}`
    
    _, err := engine.ParseAndRenderString(source, emptyBindings)
    require.NoError(t, err)
    
    engine.RemoveTag("if")
    
    _, err = engine.ParseAndRenderString(source, emptyBindings)
    require.Error(t, err)
})

Copilot uses AI. Check for mistakes.
5 changes: 5 additions & 0 deletions render/tags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@ func (c *Config) FindTagDefinition(name string) (TagCompiler, bool) {
td, ok := c.tags[name]
return td, ok
}

// RemoveTag removes a tag definition.
func (c *Config) RemoveTag(name string) {
Copy link
Owner

@osteele osteele Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider whether this should be RemoveTag or UnregisterTag. The first reads better in isolation; the second has better symmetry with RegisterTag.

This is just a question for you, not a requirement for me to accept the PR. I'm okay with either. Don't do both though! This ends up making it harder to work with client code.

delete(c.tags, name)
}