Do not repeatedly detach and attach bonusScore for every full spinn…

…er rotation Just attaching once is enough.
osudroid · Feb 11, 2025 · b1a3e0f · b1a3e0f
1 parent dd5ab9a
commit b1a3e0f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/ru/nsu/ccfit/zuev/osu/game/GameplayModernSpinner.java b/src/ru/nsu/ccfit/zuev/osu/game/GameplayModernSpinner.java
@@ -207,14 +207,13 @@ public void update(float dt) {
                 // Clear Sprite
                 clear = true;
             } else if (Math.abs(rotations) > 1) {
-                if (bonusScore.hasParent()) {
-                    scene.detachChild(bonusScore);
-                }
                 rotations -= 1 * Math.signum(rotations);
                 bonusScore.setText(String.valueOf(bonusScoreCounter * 1000));
                 listener.onSpinnerHit(id, 1000, false, 0);
                 bonusScoreCounter++;
-                scene.attachChild(bonusScore);
+                if (!bonusScore.hasParent()) {
+                    scene.attachChild(bonusScore);
+                }
                 spinnerBonusSample.play();
                 glow.registerEntityModifier(
                     Modifiers.sequence(

diff --git a/src/ru/nsu/ccfit/zuev/osu/game/GameplaySpinner.java b/src/ru/nsu/ccfit/zuev/osu/game/GameplaySpinner.java
@@ -317,14 +317,13 @@ public void update(final float dt) {
                 scene.attachChild(clearText);
                 clear = true;
             } else if (Math.abs(rotations) > 1) {
-                if (bonusScore.hasParent()) {
-                    scene.detachChild(bonusScore);
-                }
                 rotations -= 1 * Math.signum(rotations);
                 bonusScore.setText(String.valueOf(bonusScoreCounter * 1000));
                 listener.onSpinnerHit(id, 1000, false, 0);
                 bonusScoreCounter++;
-                scene.attachChild(bonusScore);
+                if (!bonusScore.hasParent()) {
+                    scene.attachChild(bonusScore);
+                }
                 spinnerBonusSample.play();
                 float rate = 0.375f;
                 if (GameHelper.getHealthDrain() > 0) {