fix/v2: preserve valid PDA seed expressions#4817
Open
0x4ka5h wants to merge 4 commits into
Open
Conversation
|
Someone is attempting to deploy a commit to the OtterSec Team on Vercel. A member of the Team first needs to authorize it. |
swaroop-osec
approved these changes
Jul 21, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## anchor-next #4817 +/- ##
==============================================
Coverage ? 63.58%
==============================================
Files ? 126
Lines ? 13654
Branches ? 0
==============================================
Hits ? 8682
Misses ? 4972
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
swaroop-osec
requested changes
Jul 23, 2026
Collaborator
There was a problem hiding this comment.
Tests were redundant please remove one set of tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
Seed rewriting stripped meaningful
.as_ref()receivers from nontrivial expressions, and opaque init bump handling borrowed a temporary array past its lifetime.Fix
This PR preserves valid seed expressions during rewriting and gives opaque init bumps a stable binding instead of a temporary borrow. Added regression tests for seed rewrites and opaque init bumps.