Skip to content

Fix/v2 seeds program without seeds#4826

Open
0x4ka5h wants to merge 2 commits into
otter-sec:anchor-nextfrom
Otter-0x4ka5h:fix/v2-seeds-program-without-seeds
Open

Fix/v2 seeds program without seeds#4826
0x4ka5h wants to merge 2 commits into
otter-sec:anchor-nextfrom
Otter-0x4ka5h:fix/v2-seeds-program-without-seeds

Conversation

@0x4ka5h

@0x4ka5h 0x4ka5h commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Finding

seeds::program = ... without seeds = [...] was accepted in lang-v2, but it emitted no PDA verification at all. That silently disabled the intended seeds check.

Fix

This PR rejects seeds::program unless seeds is also present, matching v1 behavior and preventing the missing-verification path.

Regression tests added.

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the OtterSec Team on Vercel.

A member of the Team first needs to authorize it.

@0x4ka5h
0x4ka5h requested a review from renato-osec July 20, 2026 16:11
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (anchor-next@e056cc1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
lang-v2/derive/src/parse.rs 33.33% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff               @@
##             anchor-next    #4826   +/-   ##
==============================================
  Coverage               ?   63.59%           
==============================================
  Files                  ?      126           
  Lines                  ?    13669           
  Branches               ?        0           
==============================================
  Hits                   ?     8693           
  Misses                 ?     4976           
  Partials               ?        0           
Flag Coverage Δ
v2 63.59% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants