Fix/spl-v2 metadata cpi mutability#4838
Open
0x4ka5h wants to merge 2 commits into
Open
Conversation
|
Someone is attempting to deploy a commit to the OtterSec Team on Vercel. A member of the Team first needs to authorize it. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## anchor-next #4838 +/- ##
==============================================
Coverage ? 63.60%
==============================================
Files ? 126
Lines ? 13663
Branches ? 0
==============================================
Hits ? 8691
Misses ? 4972
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
swaroop-osec
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
spl-v2treatedRevokeCollectionAuthority.delegate_authorityandSetCollectionSize.update_authorityas writable CPI accounts. Those accounts are not required to be writable by the Metaplex collection instructions, so the wrapper over-constrained callers and required unnecessary mutable borrows.Fix
Changed both fields to readonly
CpiHandles and normalized the emitted CPI instruction metas to readonly for those slots. This keeps the v2 metadata CPI surface aligned with the underlying instruction contract.