Skip to content

Conversation

@Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Prevent synchronous finalizers from running in ExternalStringImpl::create

How did you verify your code works?

@Jarred-Sumner Jarred-Sumner requested a review from 190n April 9, 2025 23:34
@robobun
Copy link
Collaborator

robobun commented Apr 9, 2025

Updated 5:12 PM PT - Apr 9th, 2025

@Jarred-Sumner, your commit 1c3b477081134917699a702a2eb13b7b6cf734a0 passed in Build #14747! 🎉


🧪   try this PR locally:

bunx bun-pr 18914

Copy link
Contributor

@190n 190n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may need to be rewritten again after #18767, but this is fine for now (on that PR once i finish fixing finalizers i will make sure all existing APIs with finalizers route through whatever i come up with)

@Jarred-Sumner Jarred-Sumner merged commit 950ce32 into main Apr 10, 2025
64 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/fix-finalizer-externalstringimpl branch April 10, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants