Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): fix exports #232

Merged
merged 5 commits into from
Oct 11, 2023
Merged

fix(datepicker): fix exports #232

merged 5 commits into from
Oct 11, 2023

Conversation

Leotheluck
Copy link
Contributor

Adding exports for odsDatepickerValueChange, odsDatepickerValueChangeEventDetail, ODS_DATEPICKER_DAY & ODS_DATEPICKER_DAYS inside public-api.ts

Adding build:ci command

Adding formattedValue inside odsDatepickerValueChange event.

@Leotheluck Leotheluck requested a review from a team as a code owner October 5, 2023 09:50
dpellier
dpellier requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@dpellier dpellier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're using flatMap in the code.
You need to update the root tsconfig.json lib like:

"lib": ["dom", "es2018", "esnext.array", "es2019"],

packages/components/datepicker/src/components/osds-datepicker/osds-datepicker.tsx Outdated Show resolved Hide resolved
@dpellier dpellier merged commit 9af539b into master Oct 11, 2023
9 of 10 checks passed
@dpellier dpellier deleted the fix/datepicker-exports branch October 11, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aesteves60 aesteves60 aesteves60 approved these changes

@dpellier dpellier dpellier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leotheluck @dpellier @aesteves60