[milestone/11.5] Milestone 11.5

.github/ISSUE_TEMPLATE/release_template.md

@@ -21,6 +21,8 @@ Xcode version to work with:
 - [ ] [TRFX] Check for missing translations. Ping @cscherm
 - [ ] [DIS] Update [changelog](https://github.com/owncloud/ios-app/blob/master/CHANGELOG.md)
 - [ ] [DEV] Update In-App Release Notes (changelog) in ownCloud/Release Notes/ReleaseNotes.plist
+- [ ] [DEV] Changelog: Created a folder for the new version like $majorVersion.$minorVersion.$patchVersion_YYYY-MM-DD
+- [ ] [DEV] Changelog: Moved all changelog files from the unreleased folder to the new version folder
 - [ ] [QA] Design Test plan
 - [ ] [QA] Regression Test plan
 - [ ] [DOC] Update user manual with the new functionalities

.github/pull_request_template.md

@@ -40,4 +40,5 @@ Please note that any kind of change first has to be submitted to the master bran
 - [ ] I have read the [**CONTRIBUTING**](https://github.com/owncloud/ios-app/blob/master/CONTRIBUTING.md) document.
 - [ ] I have added tests to cover my changes.
 - [ ] All new and existing tests passed.
+- [ ] Added changelog files for the fixed issues in folder changelog/unreleased
 

.github/workflows/calens.yml

@@ -0,0 +1,26 @@
+name: Calens Changelog
+# This workflow is triggered on pushes to the repository.
+on:
+  push:
+    branches:
+    - fix/*
+    - feature/*
+    - milestone/*
+
+jobs:
+  build:
+    runs-on: ubuntu-18.04
+    name: Generate Calens Changelog
+    steps:
+      - uses: actions/checkout@v2
+      - name: Run Calens Docker
+        uses: addnab/docker-run-action@v1
+        with:
+          options: -v ${{github.workspace}}:/workspace -w /workspace
+          image: toolhippie/calens:latest
+          run: calens >| CHANGELOG.md
+      - name: Commit files
+        uses: stefanzweifel/git-auto-commit-action@v4
+        with:
+          commit_message: Calens changelog updated
+          file_pattern: CHANGELOG.md

.gitmodules

@@ -1,6 +1,3 @@
 [submodule "ios-sdk"]
 	path = ios-sdk
 	url = https://github.com/owncloud/ios-sdk.git
-[submodule "PocketSVG"]
-	path = external/PocketSVG
-	url = https://github.com/pocketsvg/PocketSVG.git

.swiftlint.yml

@@ -34,6 +34,7 @@ disabled_rules:
     - implicit_getter
     - computed_accessors_order
     - unneeded_notification_center_removal
+    - function_parameter_count
 custom_rules:
   empty_line_after_guard_statement:
     included: ".*\\.swift"

CHANGELOG.md

@@ -1,4 +1,176 @@
-# ChangeLog
+Changelog for ownCloud iOS Client [11.5.0] (2020-02-10)
+=======================================
+The following sections list the changes in ownCloud iOS Client 11.5.0 relevant to
+ownCloud admins and users.
+
+
+
+Summary
+-------
+
+* Bugfix - Added paragraph on top of Acknowledgements page: [#4284](https://github.com/owncloud/enterprise/issues/4284)
+* Bugfix - Fixed Branded UI on iPad: [#4367](https://github.com/owncloud/enterprise/issues/4367)
+* Bugfix - Improved AppStore Review Request Time: [#845](https://github.com/owncloud/ios-app/pull/845)
+* Bugfix - Changed wording in documentation: [#867](https://github.com/owncloud/ios-app/pull/867)
+* Bugfix - Fix bookmark name editing: [#877](https://github.com/owncloud/ios-app/pull/877)
+* Bugfix - Media Player Behaviour: [#884](https://github.com/owncloud/ios-app/pull/884)
+* Change - MDM Enhancements: [#4104](https://github.com/owncloud/enterprise/issues/4104)
+* Change - Full Screen PDF View: [#428](https://github.com/owncloud/ios-app/issues/428)
+* Change - Unified Branding with MDM support: [#697](https://github.com/owncloud/ios-app/issues/697)
+* Change - Class Settings Metadata Support: [#831](https://github.com/owncloud/ios-app/issues/831)
+* Change - Video upload improvements: [#847](https://github.com/owncloud/ios-app/issues/847)
+* Change - Enhanced drag & drop support: [#850](https://github.com/owncloud/ios-app/pull/850)
+* Change - New photo picker / permissions model for iOS 14: [#851](https://github.com/owncloud/ios-app/issues/851)
+* Change - Corporate Color + UI Refinements: [#860](https://github.com/owncloud/ios-app/issues/860)
+* Change - Improved Right-to-Left Language UI-Design: [#861](https://github.com/owncloud/ios-app/issues/861)
+* Change - Enforce User ID when updating token-based bookmarks: [#869](https://github.com/owncloud/ios-app/pull/869)
+* Change - TLS certificate comparison: [#872](https://github.com/owncloud/ios-app/pull/872)
+* Change - New Issue view / presentation: [#874](https://github.com/owncloud/ios-app/pull/874)
+* Change - Automated Calens Changelog Creation: [#879](https://github.com/owncloud/ios-app/pull/879)
+
+Details
+-------
+
+* Bugfix - Added paragraph on top of Acknowledgements page: [#4284](https://github.com/owncloud/enterprise/issues/4284)
+
+   - adds a paragraph on top of the Acknowledgements to provide additional context - adds
+   PLCrashReporter license to acknowledgements
+
+   https://github.com/owncloud/enterprise/issues/4284
+
+* Bugfix - Fixed Branded UI on iPad: [#4367](https://github.com/owncloud/enterprise/issues/4367)
+
+   - UI fix for branded login on the iPad - Fill color for branded button was not used
+
+   https://github.com/owncloud/enterprise/issues/4367
+   https://github.com/owncloud/enterprise/issues/4366
+
+* Bugfix - Improved AppStore Review Request Time: [#845](https://github.com/owncloud/ios-app/pull/845)
+
+   Changed request time for In-App review and fixed storing the first launch date
+
+   https://github.com/owncloud/ios-app/pull/845
+
+* Bugfix - Changed wording in documentation: [#867](https://github.com/owncloud/ios-app/pull/867)
+
+   Changed wording so it no longer suggests username is editable
+
+   https://github.com/owncloud/ios-app/pull/867
+
+* Bugfix - Fix bookmark name editing: [#877](https://github.com/owncloud/ios-app/pull/877)
+
+   When editing bookmarks:
+
+   - if a name was set, it wasn't shown in the edit interface - bookmark name edits/additions would
+   get lost - bookmark name edits would not be presented in the list unless scrolling out of view and
+   back in
+
+   https://github.com/owncloud/ios-app/pull/877
+
+* Bugfix - Media Player Behaviour: [#884](https://github.com/owncloud/ios-app/pull/884)
+
+   Fix for an issue when playing multiple items in the same directory. If e.g. image item is the next
+   one, multi media playback would stop.
+
+   https://github.com/owncloud/ios-app/pull/884
+
+* Change - MDM Enhancements: [#4104](https://github.com/owncloud/enterprise/issues/4104)
+
+   - Passcode lock enforcement via class setting. User can be forced to set-up a passcode when he
+   first starts the app - Auto-generated MDM documentation
+
+   https://github.com/owncloud/enterprise/issues/4104
+
+* Change - Full Screen PDF View: [#428](https://github.com/owncloud/ios-app/issues/428)
+
+   - A PDF file can be opened in fullscreen view and hides unnecessary UI elements. (Tap to trigger
+   full screen view) - Thumbnails positioned based on vertical size class after rotating the
+   device to give the displayed document more screen real estate.
+
+   https://github.com/owncloud/ios-app/issues/428
+
+* Change - Unified Branding with MDM support: [#697](https://github.com/owncloud/ios-app/issues/697)
+
+   Refactored Branding, introducing a new Branding class, unifying branding support with class
+   settings while offering support for the legacy format and laying the ground for retrieving
+   branding assets from a remote server.
+
+   https://github.com/owncloud/ios-app/issues/697
+   https://github.com/owncloud/ios-app/issues/792
+
+* Change - Class Settings Metadata Support: [#831](https://github.com/owncloud/ios-app/issues/831)
+
+   Support for class settings metadata.
+
+   https://github.com/owncloud/ios-app/issues/831
+
+* Change - Video upload improvements: [#847](https://github.com/owncloud/ios-app/issues/847)
+
+   - Added ability to upload slo-mo videos etc - Added option to allow uploading original videos
+
+   https://github.com/owncloud/ios-app/issues/847
+
+* Change - Enhanced drag & drop support: [#850](https://github.com/owncloud/ios-app/pull/850)
+
+   Fix drag and drop and improve support to run the iOS app on M1 Macs:
+
+   - add drag-out support for files that are not locally available yet - improve drag-in support
+   for files, picking the best available representation that can be retrieved as data - support
+   for drag & drop in the log file browser
+
+   https://github.com/owncloud/ios-app/pull/850
+
+* Change - New photo picker / permissions model for iOS 14: [#851](https://github.com/owncloud/ios-app/issues/851)
+
+   - Using new PHPhotoPicker introduced in iOS14 instead of our custom picker. - Dealing with the
+   photo permission model introduced in iOS14 where user can grant access just to specific photo
+   assets or albums
+
+   https://github.com/owncloud/ios-app/issues/851
+
+* Change - Corporate Color + UI Refinements: [#860](https://github.com/owncloud/ios-app/issues/860)
+
+   The corporate color of the UI themes was updated and furthermore some colors was adopted for a
+   better contrast. This PR includes also some refinements for some UI elements.
+
+   https://github.com/owncloud/ios-app/issues/860
+
+* Change - Improved Right-to-Left Language UI-Design: [#861](https://github.com/owncloud/ios-app/issues/861)
+
+   Fixed missing views, which missed Right-to-Left language support.
+
+   https://github.com/owncloud/ios-app/issues/861
+
+* Change - Enforce User ID when updating token-based bookmarks: [#869](https://github.com/owncloud/ios-app/pull/869)
+
+   This PR requires the user ID to remain the same when updating token-based bookmarks. If the user
+   logs in as a user other than the one with which the bookmark was originally created, an error will
+   be presented.
+
+   https://github.com/owncloud/ios-app/pull/869
+
+* Change - TLS certificate comparison: [#872](https://github.com/owncloud/ios-app/pull/872)
+
+   When logging into an account and experiencing a different certificate that does not fulfill
+   the rules for automatic acceptance as replacement, the issue it brings up now shows the
+   differences between the two certificates to allow an informed decision by the user.
+
+   https://github.com/owncloud/ios-app/pull/872
+
+* Change - New Issue view / presentation: [#874](https://github.com/owncloud/ios-app/pull/874)
+
+   As fixing an iPad layout issue in the old issues view proved too cumbersome, I've replaced the
+   entire implementation with a new issue view, based on code already there and in use for cards and
+   tables.
+
+   https://github.com/owncloud/ios-app/pull/874
+
+* Change - Automated Calens Changelog Creation: [#879](https://github.com/owncloud/ios-app/pull/879)
+
+   This PR uses GitHub Actions to automatically generate a changelog file with Calens and commits
+   the new CHANGELOG.md into the current branch.
+
+   https://github.com/owncloud/ios-app/pull/879
 
 ## Release version 11.4.5 (January 2021)
 

Gemfile.lock

@@ -6,51 +6,52 @@ GEM
       public_suffix (>= 2.0.2, < 5.0)
     atomos (0.1.3)
     aws-eventstream (1.1.0)
-    aws-partitions (1.376.0)
-    aws-sdk-core (3.108.0)
+    aws-partitions (1.394.0)
+    aws-sdk-core (3.109.3)
       aws-eventstream (~> 1, >= 1.0.2)
       aws-partitions (~> 1, >= 1.239.0)
       aws-sigv4 (~> 1.1)
       jmespath (~> 1.0)
-    aws-sdk-kms (1.38.0)
-      aws-sdk-core (~> 3, >= 3.99.0)
+    aws-sdk-kms (1.39.0)
+      aws-sdk-core (~> 3, >= 3.109.0)
       aws-sigv4 (~> 1.1)
-    aws-sdk-s3 (1.81.1)
-      aws-sdk-core (~> 3, >= 3.104.3)
+    aws-sdk-s3 (1.84.1)
+      aws-sdk-core (~> 3, >= 3.109.0)
       aws-sdk-kms (~> 1)
       aws-sigv4 (~> 1.1)
     aws-sigv4 (1.2.2)
       aws-eventstream (~> 1, >= 1.0.2)
-    babosa (1.0.3)
-    badge (0.11.0)
+    babosa (1.0.4)
+    badge (0.12.0)
       curb (~> 0.9)
       fastimage (>= 1.6)
       fastlane (>= 2.0)
-      mini_magick (~> 4.9.5)
+      mini_magick (>= 4.9.4, < 5.0.0)
     claide (1.0.3)
     colored (1.2)
     colored2 (3.1.2)
     commander-fastlane (4.4.6)
       highline (~> 1.7.2)
-    curb (0.9.10)
+    curb (0.9.11)
     declarative (0.0.20)
     declarative-option (0.1.0)
     digest-crc (0.6.1)
       rake (~> 13.0)
     domain_name (0.5.20190701)
       unf (>= 0.0.5, < 1.0.0)
     dotenv (2.7.6)
-    emoji_regex (3.0.0)
-    excon (0.76.0)
-    faraday (1.0.1)
+    emoji_regex (3.2.1)
+    excon (0.78.0)
+    faraday (1.1.0)
       multipart-post (>= 1.2, < 3)
+      ruby2_keywords
     faraday-cookie_jar (0.0.7)
       faraday (>= 0.8.0)
       http-cookie (~> 1.0.0)
     faraday_middleware (1.0.0)
       faraday (~> 1.0)
     fastimage (2.2.0)
-    fastlane (2.160.0)
+    fastlane (2.167.0)
       CFPropertyList (>= 2.3, < 4.0.0)
       addressable (>= 2.3, < 3.0.0)
       aws-sdk-s3 (~> 1.0)
@@ -86,8 +87,8 @@ GEM
       xcodeproj (>= 1.13.0, < 2.0.0)
       xcpretty (~> 0.3.0)
       xcpretty-travis-formatter (>= 0.0.3)
-    fastlane-plugin-badge (1.3.0)
-      badge (~> 0.11.0)
+    fastlane-plugin-badge (1.4.0)
+      badge (~> 0.12.0)
     fastlane-plugin-json (1.0.0)
     gh_inspector (1.1.3)
     google-api-client (0.38.0)
@@ -101,17 +102,17 @@ GEM
     google-cloud-core (1.5.0)
       google-cloud-env (~> 1.0)
       google-cloud-errors (~> 1.0)
-    google-cloud-env (1.3.3)
+    google-cloud-env (1.4.0)
       faraday (>= 0.17.3, < 2.0)
     google-cloud-errors (1.0.1)
-    google-cloud-storage (1.29.0)
+    google-cloud-storage (1.29.1)
       addressable (~> 2.5)
       digest-crc (~> 0.4)
       google-api-client (~> 0.33)
       google-cloud-core (~> 1.2)
       googleauth (~> 0.9)
       mini_mime (~> 1.0)
-    googleauth (0.13.1)
+    googleauth (0.14.0)
       faraday (>= 0.17.3, < 2.0)
       jwt (>= 1.4, < 3.0)
       memoist (~> 0.16)
@@ -126,7 +127,7 @@ GEM
     json (2.3.1)
     jwt (2.2.2)
     memoist (0.16.2)
-    mini_magick (4.9.5)
+    mini_magick (4.11.0)
     mini_mime (1.0.2)
     multi_json (1.15.0)
     multipart-post (2.0.0)
@@ -142,6 +143,7 @@ GEM
       uber (< 0.2.0)
     retriable (3.1.2)
     rouge (2.0.7)
+    ruby2_keywords (0.0.2)
     rubyzip (2.3.0)
     security (0.1.3)
     signet (0.14.0)
@@ -166,7 +168,7 @@ GEM
     unf_ext (0.0.7.7)
     unicode-display_width (1.7.0)
     word_wrap (1.0.0)
-    xcodeproj (1.18.0)
+    xcodeproj (1.19.0)
       CFPropertyList (>= 2.3.3, < 4.0)
       atomos (~> 0.1.3)
       claide (>= 1.0.2, < 2.0)

Podfile.lock

@@ -13,4 +13,4 @@ SPEC CHECKSUMS:
 
 PODFILE CHECKSUM: 9075b8f92281024401a0039c3477c9a16650b092
 
-COCOAPODS: 1.9.3
+COCOAPODS: 1.10.0

changelog/11.5.0_2020-02-10/4104

@@ -0,0 +1,6 @@
+Change: MDM Enhancements
+
+- Passcode lock enforcement via class setting. User can be forced to set-up a passcode when he first starts the app
+- Auto-generated MDM documentation
+
+https://github.com/owncloud/enterprise/issues/4104

changelog/11.5.0_2020-02-10/428

@@ -0,0 +1,6 @@
+Change: Full Screen PDF View
+
+- A PDF file can be opened in fullscreen view and hides unnecessary UI elements. (Tap to trigger full screen view)
+- Thumbnails positioned based on vertical size class after rotating the device to give the displayed document more screen real estate.
+
+https://github.com/owncloud/ios-app/issues/428

changelog/11.5.0_2020-02-10/4284

@@ -0,0 +1,6 @@
+Bugfix: Added paragraph on top of Acknowledgements page
+
+- adds a paragraph on top of the Acknowledgements to provide additional context
+- adds PLCrashReporter license to acknowledgements
+
+https://github.com/owncloud/enterprise/issues/4284

changelog/11.5.0_2020-02-10/4367

@@ -0,0 +1,7 @@
+Bugfix: Fixed Branded UI on iPad
+
+- UI fix for branded login on the iPad
+- Fill color for branded button was not used
+
+https://github.com/owncloud/enterprise/issues/4367
+https://github.com/owncloud/enterprise/issues/4366