Skip to content

[fix/new-review-request] Improved AppStore Review Request Time #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hosy merged 2 commits into from
Jan 28, 2021
Merged

[fix/new-review-request] Improved AppStore Review Request Time #845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a7ed34
show the AppStore review request dialog in faster time interval
hosy Nov 26, 2020
48cdc8a
- AppStatistics: fix overwrite of .launchDate with .updateDate and co…
felix-schwarz Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ownCloudAppShared/Tools/AppStatistics.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,16 @@ public class AppStatistics {
}

// Reset update launch date if current version is different compared to stored ones
if let lastVersion = userDefaults.object(forKey: UserDefaultsKeys.lastInstalledVersion.rawValue) as? String {
if lastVersion != appVersion {
if let lastInstalledVersion = userDefaults.object(forKey: UserDefaultsKeys.lastInstalledVersion.rawValue) as? String {
if lastInstalledVersion != appVersion {
self.updateDate = Date()
}
}

// Update user defaults except for review prompt time stamp updated separately
userDefaults.set(self.launchDate, forKey: UserDefaultsKeys.firstLaunchDate.rawValue)
userDefaults.set(self.launchDate, forKey: UserDefaultsKeys.firstLaunchDate.rawValue)
userDefaults.set(self.updateDate, forKey: UserDefaultsKeys.updateDate.rawValue)
userDefaults.set(self.appVersion, forKey: UserDefaultsKeys.lastInstalledVersion.rawValue)
userDefaults.set(self.updateDate, forKey: UserDefaultsKeys.firstLaunchDate.rawValue)

// Persist user defaults
userDefaults.synchronize()
Expand Down
8 changes: 4 additions & 4 deletions ownCloudAppShared/Tools/VendorServices.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,14 +260,14 @@ public class VendorServices : NSObject {
// Make sure there is at least one bookmark configured, to not bother users who have never configured any accounts
guard OCBookmarkManager.shared.bookmarks.count > 0 else { return }

// Make sure at least 14 days have elapsed since the first launch of the app
guard AppStatistics.shared.timeIntervalSinceFirstLaunch.days >= 14 else { return }
// Make sure at least 7 days have elapsed since the first launch of the app
guard AppStatistics.shared.timeIntervalSinceFirstLaunch.days >= 7 else { return }

// Make sure at least 7 days have elapsed since first launch of current version
guard AppStatistics.shared.timeIntervalSinceUpdate.days >= 7 else { return }

// Make sure at least 230 have elapsed since last prompting
AppStatistics.shared.requestAppStoreReview(onceInDays: 230)
// Make sure at least 122 have elapsed since last prompting (Apple allows to show the dialog 3 times per 365 days)
AppStatistics.shared.requestAppStoreReview(onceInDays: 122)
}
}

Expand Down