Video upload improvements #852

mneuwert · 2020-12-19T22:49:32Z

Description

Add ability to upload slo-mo videos etc
Add option to allow uploading original videos

Related Issue

#847

Motivation and Context

More flexibility for photo uploads

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

Fixes slow motion video upload and other types of video relying on applying transformation data to originally shot footage

CLAassistant · 2020-12-19T22:49:38Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Michael Neuwert
❌ felix-schwarz

Michael Neuwert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…upload_original_video

michaelstingl · 2020-12-23T00:42:05Z

Add ability to upload slo-mo videos etc

Looks very good 👍

michaelstingl · 2020-12-23T00:54:19Z

Hm, interesting. Apple's new 10bit Dolby Vision format doesn't get re-encoded at all:

michaelstingl · 2020-12-23T01:08:07Z

I found, "Prefer original videos" is only respected when upload is initiated from inside the app. Video uploads initiated from Photos app via Share Sheet or via FileProvider always have "Preparing" phase before upload, so they get re-encoded. Add a note under the switch?

mneuwert · 2020-12-23T18:39:34Z

@michaelstingl hm.. actually these shall be uploaded as is without any processing. It can be any binary file not just video, right?

michaelstingl · 2021-01-02T17:18:20Z

Check Settings > Media upload:

“Prefer original videos” and “Prefer RAW photos” seems connected. Enabling the one, also enabled the other. Disabling results in same behavior:

B6FD2EC3-ECAC-49D2-85FF-D78277CC2082.MOV

…h "Prefer RAW photos"

mneuwert · 2021-01-10T15:39:55Z

Check Settings > Media upload:

“Prefer original videos” and “Prefer RAW photos” seems connected. Enabling the one, also enabled the other. Disabling results in same behavior:

B6FD2EC3-ECAC-49D2-85FF-D78277CC2082.MOV

This is fixed with latest commit

hosy · 2021-01-14T09:09:56Z

fastlane/Fastfile

+    #if values[:BETA_APP_ICON]
+    #  commit = last_git_commit
+    #  short_hash = commit[:abbreviated_commit_hash] # short sha of commit
+    #  sh "brew install librsvg"
+    #  sh "sed -e \"s/\#version#/" + version + "/\" -e \"s/\#githash#/" + short_hash + "/\" badge.svg > badge_tmp.svg"
+    #  sh "rsvg-convert badge_tmp.svg > badge.png"
+    #  add_badge(custom: "fastlane/badge.png")
+    #end


This needs to be uncommented

I commented that out because it failed and prevented Bitrise builds a few weeks ago (IIRC). When putting it back in, please check whether IPAs are still being built.

Should be fixed with the latest master merged inside

hosy · 2021-01-14T09:13:22Z

ownCloud/Settings/ProPhotoUploadSettingsSection.swift


 		self.add(row: preferOriginalsRow)

-		if AVCaptureDevice.rawCameraDeviceAvailable() {


Why did you remove the if clause? Raw camera support is not available on every device.

Why did you remove the if clause? Raw camera support is not available on every device.

What about raw files stored on devices without the latest camera? I created the file in iPhone 12 Pro Max, but did my upload testing with the iPhone 8 test device.

Ok, good point. I missed that option!

@hosy that was exactly the intension to allow users upload RAW photos from their iCloud synced photo library shot on more capable device.

jesmrec · 2021-01-15T10:18:10Z

Checked the slo-mo videos, they are correctly uploaded and played. @michaelstingl collected all relevant encoding info above.

About uploading original videos:

Settings option works fine. It is only visible in enterprise version servers, and under Prefer original videos IAP feature
Option enabled + video edited = upload video without the edit.
Option disabled + video edited = upload video with the edit.
An original video is always correctly uploaded, no matter the Setting value

About encoding, i will add a report about the edited video with and without the Setting enabled. For me it's ok, but you can take a look if any parameter is more relevant

Original	Edited

Tested with: iPhoneXR v14.2, iPadAir v13

jesmrec · 2021-01-19T07:16:52Z

Approved

Michael Neuwert added 2 commits November 25, 2020 22:18

Always going through export session when uploading video

44a2a7d

Fixes slow motion video upload and other types of video relying on applying transformation data to originally shot footage

Added settings option to prefer original videos

5768309

mneuwert added the feature:uploads all kind of uploads label Dec 19, 2020

mneuwert added this to the 11.5.0-Next milestone Dec 19, 2020

mneuwert self-assigned this Dec 19, 2020

mneuwert linked an issue Dec 19, 2020 that may be closed by this pull request

Check: Upload video files without re-conversion #847

Closed

Michael Neuwert and others added 2 commits December 20, 2020 19:44

Merge commit '9a985067776672fc6a9d9287e21a02bad30d5fe2' into feature/…

67b3331

…upload_original_video

- comment out commit badge (as it fails Bitrise builds)

d85fa37

michaelstingl mentioned this pull request Dec 23, 2020

Small size difference in videos automatically uploaded owncloud/ios-legacy#1040

Closed

Fixed a problem with "Prefer original videos" option interferring wit…

b83eadd

…h "Prefer RAW photos"

hosy requested changes Jan 14, 2021

View reviewed changes

hosy requested a review from jesmrec January 14, 2021 09:14

felix-schwarz approved these changes Jan 14, 2021

View reviewed changes

jesmrec approved these changes Jan 19, 2021

View reviewed changes

jesmrec added the Approved by QA Approved by QA label Jan 19, 2021

jesmrec merged commit df3d1fb into milestone/11.5 Jan 21, 2021

delete-merged-branch bot deleted the feature/upload_original_video branch January 21, 2021 08:47


		self.add(row: preferOriginalsRow)

		if AVCaptureDevice.rawCameraDeviceAvailable() {

Video upload improvements #852

Video upload improvements #852

Uh oh!

Conversation

mneuwert commented Dec 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

CLAassistant commented Dec 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelstingl commented Dec 23, 2020

Uh oh!

michaelstingl commented Dec 23, 2020

Uh oh!

michaelstingl commented Dec 23, 2020

Uh oh!

mneuwert commented Dec 23, 2020

Uh oh!

michaelstingl commented Jan 2, 2021

Uh oh!

mneuwert commented Jan 10, 2021

Uh oh!

hosy Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

felix-schwarz Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

hosy Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

hosy Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

michaelstingl Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

hosy Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

mneuwert Jan 14, 2021

Choose a reason for hiding this comment

Uh oh!

jesmrec commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jesmrec commented Jan 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mneuwert commented Dec 19, 2020 •

edited

Loading

CLAassistant commented Dec 19, 2020 •

edited

Loading

jesmrec commented Jan 15, 2021 •

edited

Loading