[iOS 14] New photo picker / permissions model

[mneuwert]

Description

• Using new PHPhotoPicker introduced in iOS14 instead of our custom picker.
• Dealing with the photo permission model introduced in iOS14 where user can grant access just to specific photo assets or albums.

Related Issue

#851

Motivation and Context

• New photo picker in iOS14 has got an album tab and allows searching based on people faces, objects, locations etc.
• Since the user can limit the access, we could provide a convenient UI option allowing to raise access level without the need opening the Settings app.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

QA

Test plan:

Bugs & improvements:

• (1) Bad UX in Selected option [iOS 14] New photo picker / permissions model #853 (comment) [FIXED]

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Michael Neuwert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[mneuwert]

@michaelstingl Improved photo selection process on iOS14 using new picker:

• If limited access feature allowing to disable access to certain photos is not active, everything just works.
• If user limits access to certain photos / videos, they can be selected.. And then similar picker used by the system to change permissions is presented allowing the user to revise his choice regarding limited access and to grant access.. (however it is a pity you can't actually highlight stuff which is selected for upload but is missing access permission).
• When user confirms his new limited access selection, then assets are re-fetched and if they are available, then they are uploaded. If none of the assets are accessible, warning alert is shown.

[hosy]

Great work!

[mneuwert]

@hosy Thanks! Appreciate!

[jesmrec]

I have to finish QA here it. First rounds seems pretty good.

(1)

Just one comment. Check these steps out:

1. In Device > Settings > ownCloud > Photos, select Selected Photos
2. Select some photos there
3. in ownCloud app, select Upload from Photo Library
4. Select photos that were not selected in step 2.

at this point, i expected an alert error, letting user know that it is not allowed (lack of permissions). Something similar to the error that happens when None is selected in step 1.

Instead, the selecting view (the same view that appears in step 1) is displayed to allow users to select new items to allow them for the app. This could be a little confusing, but my question is: is that way to do iOS-native? or is something implemented for the feature?

[mneuwert]

I have to finish QA here it. First rounds seems pretty good.

Just one comment. Check these steps out:

1. In Device > Settings > ownCloud > Photos, select Selected Photos
2. Select some photos there
3. in ownCloud app, select Upload from Photo Library
4. Select photos that were not selected in step 2.

at this point, i expected an alert error, letting user know that it is not allowed (lack of permissions). Something similar to the error that happens when None is selected in step 1.

Instead, the selecting view (the same view that appears in step 1) is displayed to allow users to select new items to allow them for the app. This could be a little confusing, but my question is: is that way to do iOS-native? or is something implemented for the feature?

• That's in fact confusing since new photo picker shows all pictures irrespective of photo library permissions.
• So, if you try to fetch photos which are not available (but you have selected them), second almost identical picker is shown allowing to add more permissions. It comes from the system and there is no way to customise it.
• So, if you don't implement special handling, this second picker is appearing only once and if user doesn't change permissions, he is never asked again by the system. I did try to improve this though.. There is a way to suppress it via setting special key in Info.plist and to trigger it manually. But again, you can just tell the system to show it and can't pass any parameters or so... The only improvement I managed to achieve is: it is always consistently shown whenever current permissions don't match the selection of assets to upload.

So there are some tradeoffs when using new photo picker...

[michaelstingl]

Before Apple’s dialogue pops up, could we show an own thing, that tells users what to do?

[mneuwert]

Before Apple’s dialogue pops up, could we show an own thing, that tells users what to do?

yes, we could.. There is actually some text on top of Apple's dialogue, but I agree that it is eventually barely noticeable

[mneuwert]

Before Apple’s dialogue pops up, could we show an own thing, that tells users what to do?

Added an alert conveying that access to media is limited, then when user taps " Change" Apple's dialogue is shown, where photos to which access is granted are displayed with a checkmark.

[jesmrec]

Added an alert conveying that access to media is limited, then when user taps " Change" Apple's dialogue is shown, where photos to which access is granted are displayed with a checkmark.

that's much better

[jesmrec]

Approved on my side