[feature/mdm+branding] Unified Branding with MDM support

[felix-schwarz]

Description

Refactored Branding, introducing a new Branding class, unifying branding support with class settings while offering support for the legacy format and laying the ground for retrieving branding assets from a remote server.

The Branding.plist stays in place, but now every key in it has been replaced with a class setting:

Original key path	Replacement ClassSettings flat identifier
URLs / Documentation	branding.url-documentation
URLs / Help	branding.url-help
URLs / Privacy	branding.url-privacy
URLs / TermsOfUse	branding.url-terms-of-use
feedbackMail	branding.send-feedback-address
canAddAccount	branding.can-add-account
canEditAccount	branding.can-edit-account
Profiles	branding.profile-definitions
Generic	branding.theme-generic-colors
Themes	branding.theme-definition

Example for an old Branding.plist (still supported via legacy support):

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>canAddAccount</key>
	<false/>
	<key>canEditAccount</key>
	<true/>
	<key>organizationName</key>
	<string>ownCloud.online</string>
	<key>feedbackMail</key>
	<string></string>
	<key>Configuration</key>
	<dict/>
	<key>Profiles</key>
	<array>
		<dict>
			<key>identifier</key>
			<string>ownCloud.online</string>
			<key>name</key>
			<string>ownCloud.online</string>
			<key>welcome</key>
			<string>Welcome to ownCloud.online</string>
			/* … */
		</dict>
	</array>
	<key>URLs</key>
	<dict>
		<key>Help</key>
		<string>https://owncloud.online/faq/</string>
		<key>Privacy</key>
		<string>https://owncloud.online/privacy-policy/</string>
	</dict>
	<key>Generic</key>
	<dict>
		<key>Corporate</key>
		<dict>
			<key>Color</key>
			<string>#52DDA9</string>
		</dict>
		/* … */
	</dict>
	<key>Themes</key>
	<array>
		<dict>
			<key>Name</key>
			<string>ownCloud.online</string>
			/* … */
		</dict>
	</array>
</dict>
</plist>

Example for Branding.plist using new format:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>branding.can-add-account</key>
	<false/>
	<key>branding.can-edit-account</key>
	<true/>
	<key>branding.organization-name</key>
	<string>ownCloud.online</string>
	<key>branding.send-feedback-address</key>
	<string></string>
	<key>branding.profile-definitions</key>
	<array>
		<dict>
			<key>identifier</key>
			<string>ownCloud.online</string>
			<key>name</key>
			<string>ownCloud.online</string>
			<key>welcome</key>
			<string>Welcome to ownCloud.online</string>
			/* … */
		</dict>
	</array>
	<key>branding.url-help</key>
	<string>https://owncloud.online/faq/</string>
	<key>branding.url-privacy</key>
	<string>https://owncloud.online/privacy-policy/</string>
	<key>branding.theme-generic-colors</key>
	<dict>
		<key>Corporate</key>
		<dict>
			<key>Color</key>
			<string>#52DDA9</string>
		</dict>
		/* … */
	</dict>
	<key>branding.theme-definitions</key>
	<array>
		<dict>
			<key>Name</key>
			<string>ownCloud.online</string>
			/* … */
		</dict>
	</array>
</dict>
</plist>

(it is also possible to put any other parameters in here - not just branding parameters)

Configuration via MDM

All parameters previously only available through Branding.plist are now also available - in new notation - via class settings / MDM support. Documentation is available here.

Related Issue

#697 #792

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hosy
❌ felix-schwarz
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[hosy]

Nothing to add here. Awesome implementation. Thanks @felix-schwarz !

[michaelstingl]

LGTM