Skip to content

Conversation

@hosy
Copy link
Collaborator

@hosy hosy commented Jan 29, 2021

Description

  1. UI fix for branded login on the iPad
  2. Fill color for branded button was not used

Related Issue

  1. https://github.com/owncloud/enterprise/issues/4367
  2. https://github.com/owncloud/enterprise/issues/4366

Motivation and Context

Better UI experience

How Has This Been Tested?

  • Use a branded Client
  • Test UI on iPad
  • Test UI on iPhone

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…nstead using the whole screen width. On iPhone the complete screen width will be used.
@hosy hosy added this to the 11.5.0-Current milestone Jan 29, 2021
@hosy hosy requested review from jesmrec and mneuwert January 29, 2021 11:46
@hosy hosy self-assigned this Jan 29, 2021
@jesmrec
Copy link
Contributor

jesmrec commented Feb 2, 2021

  • Reduced width of the Continue button ✅
  • Branded colours of Login button ✅

Approved

CC @hosy

@jesmrec jesmrec added the Approved by QA Approved by QA label Feb 2, 2021
@hosy hosy merged commit b97d1c9 into milestone/11.5 Feb 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/branded-login-ipad-ui branch February 2, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved by QA Approved by QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants