Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer): Optional Chaining #6990

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(transformer): Optional Chaining #6990

wants to merge 6 commits into from

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Oct 29, 2024

Part of #6958

Copy link

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Oct 29, 2024
Copy link

codspeed-hq bot commented Oct 29, 2024

CodSpeed Performance Report

Merging #6990 will degrade performances by 86.61%

Comparing optional-chaining (2ddf822) with main (20fe3cd)

Summary

❌ 3 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main optional-chaining Change
transformer[cal.com.tsx] 33.5 ms 207.1 ms -83.81%
transformer[checker.ts] 18 ms 83.9 ms -78.51%
transformer[pdf.mjs] 6.6 ms 49.3 ms -86.61%

Copy link
Member

Dunqing commented Nov 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-ast Area - AST label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants