perf(tspath): add patch to avoid string allocations when lowercasing paths #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
We should have a tracking issue to remove this later in the future, assume we will rearchitect and no longer call this function so many times. |
Boshen
deleted the
c/08-15-perf_tspath_add_patch_to_avoid_string_allocations_when_lowercasing_paths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces an allocation when converting strings to lower case.
With how we are currently using project services, this function is called a ridiculous number of times, so avoiding an allocation here, allows for much less GC pressure, improving the perf of the linter.
Ref: microsoft/typescript-go#1575