Gzip response bodies #1448
Draft
Gzip response bodies #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
commented
Oct 2, 2025
| /// response.extensions_mut().insert(NoCompression); | ||
| /// ``` | ||
| #[derive(Debug, Clone, Copy)] | ||
| pub struct NoCompression; |
There was a problem hiding this comment.
This seems like a way for a dropshot handler to tell dropshot not to compress the response even though it might otherwise compress it. That's neat, but happy to get rid of it if we don't need it.
david-crespo
commented
Oct 2, 2025
| [dependencies.tokio-util] | ||
| version = "0.7" | ||
| features = [ "io", "compat" ] | ||
|
|
There was a problem hiding this comment.
Used for converting between AsyncRead/AsyncWrite from async-compression and the streams used by Body from hyper.
david-crespo
commented
Oct 2, 2025
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_gzip_compression_with_accept_encoding() { |
There was a problem hiding this comment.
This is the primary happy path test for compression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221
Needed a break so I kinda went to town here -- many rounds of review and iteration with both Claude Code and Codex. It's long as hell but it's almost all tests. Leaving as a draft for now because I want to go through it in more detail and write up a better description, but it seems pretty legit.