Document blocker for upgrading schemars to v1.0 #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
reviewed
Oct 6, 2025
Comment on lines
+90
to
+93
| # While a 1.0 version is out, there is no way to generate an OpenAPIv3 spec without adding nullable | ||
| # for all of the fields - see https://docs.rs/schemars/1.0.4/src/schemars/generate.rs.html#126 for | ||
| # how SchemaSettings::option_nullable is handled now. As the other transformers are not public | ||
| # creating our own version would take quite a bit of source code copy |
There was a problem hiding this comment.
Suggested change
| # While a 1.0 version is out, there is no way to generate an OpenAPIv3 spec without adding nullable | |
| # for all of the fields - see https://docs.rs/schemars/1.0.4/src/schemars/generate.rs.html#126 for | |
| # how SchemaSettings::option_nullable is handled now. As the other transformers are not public | |
| # creating our own version would take quite a bit of source code copy | |
| # While newer versions of schemars are available, they are not trivial for us to update to. | |
| # See oxidecomputer/dropshot#1375 for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried doing a project with dropshot and was surprised it was on an old version of schemars. I thought I would give back by upgrading. After spending some time updating schema constructions and checks to the new format, I encountered that we use a
SchemaSettingssetting which is no longer viable in the new version ofschemars. I hope you are willing to add a comment like the one in this PR to upstream to avoid another person going down the same rabbit hole.