Skip to content

gimlet: add missing temperature sensors for the ISL68224 controller #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

gimlet: add missing temperature sensors for the ISL68224 controller #2108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6220368
gimlet: add missing temperature sensors for the ISL68224 controller (…
Aaron-Hartwig Jun 23, 2025
8dd9024
fix toml formatting
Aaron-Hartwig Jun 30, 2025
f8b8110
ISL68224/RAA229618 read IC temp instead of hottest phase temp
Aaron-Hartwig Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/gimlet/base.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ device = "isl68224"
description = "DIMM/SP3 1.8V A0 power controller"
power.rails = [ "VPP_ABCD", "VPP_EFGH", "V1P8_SP3" ]
power.phases = [ [ 0 ], [ 1 ], [ 2 ] ]
sensors = { voltage = 3, current = 3 }
sensors = { temperature = 3, voltage = 3, current = 3 }
refdes = "U352"

[[config.i2c.devices]]
Expand Down
2 changes: 1 addition & 1 deletion drv/i2c-devices/src/isl68224.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ impl VoltageSensor<Error> for Isl68224 {

impl TempSensor<Error> for Isl68224 {
fn read_temperature(&self) -> Result<Celsius, Error> {
let t = pmbus_rail_read!(self.device, self.rail, READ_TEMPERATURE_1)?;
let t = pmbus_rail_read!(self.device, self.rail, READ_TEMPERATURE_2)?;
Ok(Celsius(t.get()?.0))
}
}
Expand Down
2 changes: 1 addition & 1 deletion drv/i2c-devices/src/raa229618.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ impl VoltageSensor<Error> for Raa229618 {

impl TempSensor<Error> for Raa229618 {
fn read_temperature(&self) -> Result<Celsius, Error> {
let t = pmbus_rail_read!(self.device, self.rail, READ_TEMPERATURE_1)?;
let t = pmbus_rail_read!(self.device, self.rail, READ_TEMPERATURE_2)?;
Ok(Celsius(t.get()?.0))
}
}
Expand Down