Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Reverso" is a board with the same form factor as a Gimlet which loops back the two backplane connectors.
In this configuration, packets leaving the VSC7448 destined for SP i instead arrive at the peer Sidecar, appearing to have originated at SP i.
In the unlocked VLAN configuration, this is a problem: packets can arrive at one tech port and emerge from the other tech port, which creates a routing loop. When this happens, our CM's network unceremoniously turns off the offending network port, and we have to manually get it re-enabled.
This PR adds a
VlanTargets
parameter to unlock-related code:VlanTargets::EverySp
is our existing behavior, where the technician port can communicate with every cubbyVlanTargets::ScrimletOnly
limits technician ports to only communicate with Scrimlet cubbies, which are guaranteed to be populatedBy preventing the technician port from talking to cubbies with Reverso installed, we can avoid network loops.
The switch zone in the scrimlet can still communicate with every cubby; indeed, this is how we expect to test connectivity with Reverso installed.