Skip to content

[nexus] Put support bundles in internal API #7971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 28, 2025
Merged

[nexus] Put support bundles in internal API #7971

merged 19 commits into from
Apr 28, 2025

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Apr 14, 2025

They're already in the external API, but this makes them accessible to omdb.

@smklein smklein changed the base branch from main to omicron-dev-disk-test April 15, 2025 22:52
@smklein smklein marked this pull request as ready for review April 16, 2025 16:21
Copy link
Contributor

@wfchandler wfchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but looks great.

Copy link
Contributor

@papertigers papertigers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good to me pending the small change Will noted.

Base automatically changed from omicron-dev-disk-test to main April 25, 2025 21:44
@smklein smklein enabled auto-merge (squash) April 28, 2025 17:22
@smklein smklein merged commit 71dace9 into main Apr 28, 2025
18 checks passed
@smklein smklein deleted the sb-internal-api branch April 28, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants