sled-diagnostics find_log_in_snapshot needs to be more robust #8048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
|
With this in place I collected a support bundle on london and this is a listing of the final zip: |
wfchandler
approved these changes
Apr 25, 2025
papertigers
deleted the
spr/papertigers/sled-diagnostics-find_log_in_snapshot-needs-to-be-more-robust
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing support bundle collection on london I noticed that we were not collecting archived logs properly.
Upon investigation I found the following in the sled-agent logs:
This PR makes finding the log we are operating on in a snapshot more robust by reconstructing the final log path via the ZFS snapshot mountpoint taking into account the initial log file path. As a bonus this cleans things up and removes some guess work that was previously done with delegated datasets and zone names.