Use a single workflow per commit to upload from Buildomat to Trunk #9249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
force-pushed
the
ea-nwkxxvtlvqtm
branch
2 times, most recently
from
305d358 to
4376773
Compare
sunshowers
reviewed
Oct 17, 2025
pietroalbini
force-pushed
the
ea-nwkxxvtlvqtm
branch
from
4376773 to
dc7de7f
Compare
|
Pushed a larger change that moves all of the logic back into the script. |
|
Do you want to wait on this until we've figured out the issue we were talking about where we were potentially sending the wrong JUnit file to Trunk? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iliana pointed out that the Trunk integration fills the sidebar with its workflows, hitting a limit in GitHub and thus not showing the Buildomat jobs. This was because we were spawning an upload job for every Buildomat job.
This PR switches the upload job from running when a Buildomat job finishes (with the
check_runevent) to when all Buildomat jobs finish (with thecheck_suiteevent). Then whenever the job is started we fetch all the check runs within the suite and call the script on all of them.