Skip to content

Conversation

bnaecker
Copy link
Collaborator

@bnaecker bnaecker commented Oct 17, 2025

  • Add ipv6 column to the network_interface table, and make both it
    and the ip column nullable to account for interfaces with one or
    both address families.
  • Add schema update files that recreate a bunch of views / indexes to
    account for the new columns.
  • Add a check constraint that there is at least one IP address, and
    update the code handling IP address exhaustion with that new
    constraint failure.
  • Closes Want database model support for dual-stack network interfaces #9242

@bnaecker bnaecker marked this pull request as draft October 17, 2025 23:15
@bnaecker bnaecker force-pushed the database-support-for-dual-stack-nics branch 3 times, most recently from e8f7a4d to 2160d01 Compare October 20, 2025 04:41
- Add `ipv6` column to the `network_interface` table, and make both it
  and the `ip` column nullable to account for interfaces with one or
  both address families.
- Add schema update files that recreate a bunch of views / indexes to
  account for the new columns.
- Add a check constraint that there is at least one IP address, and
  update the code handling IP address exhaustion with that new
  constraint failure.
- Closes #9242
@bnaecker bnaecker force-pushed the database-support-for-dual-stack-nics branch from 2160d01 to 1e55211 Compare October 20, 2025 20:25
@bnaecker bnaecker marked this pull request as ready for review October 20, 2025 20:25
@bnaecker bnaecker changed the title WIP: Add database support for dual-stack network interfaces Add database support for dual-stack network interfaces Oct 20, 2025
Copy link
Contributor

@rcgoodfellow rcgoodfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnaecker. LGTM just a few minor comments.

@bnaecker bnaecker merged commit 2a1d854 into main Oct 22, 2025
16 checks passed
@bnaecker bnaecker deleted the database-support-for-dual-stack-nics branch October 22, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Want database model support for dual-stack network interfaces

2 participants