Skip to content

Conversation

@p-ortega
Copy link
Owner

@p-ortega p-ortega commented Dec 1, 2025

This pull request introduces several improvements to the project's continuous integration workflows, test infrastructure, and codebase organization. The main changes include enabling scheduled CI runs, broadening workflow triggers, adding CLI-based testing, and refactoring the CLI entrypoint for better compatibility.

Continuous Integration Improvements:

  • Enabled scheduled CI runs at 8 AM UTC daily by uncommenting and activating the schedule trigger in both .github/workflows/tests_main.yml and .github/workflows/tests_macos.yml. [1] [2]
  • Broadened the pull request workflow triggers to match all feature/** branches instead of just feature/externalio. [1] [2]

Testing Enhancements:

  • Updated autotest/test_benchmark.py to support running tests via the CLI by adding a test_cli flag to run_test and invoking the mf6rtm CLI using subprocess when set. The test05 benchmark now uses this new CLI-based test path. [1] [2]

Codebase Cleanup and Refactoring:

  • Removed the __author__ and __version__ metadata from mf6rtm/__init__.py for a cleaner module interface.
  • Removed the obsolete CLI entrypoint code from mf6rtm/__main__.py to centralize CLI logic.
  • Refactored the run_cmd function in mf6rtm/simulation/solver.py to accept an optional cwd argument for improved console script compatibility and added a docstring.
  • Minor typing improvement: imported Optional in mf6rtm/simulation/solver.py.

@p-ortega p-ortega marked this pull request as draft December 19, 2025 01:22
@p-ortega p-ortega marked this pull request as ready for review January 14, 2026 12:18
@p-ortega p-ortega linked an issue Jan 14, 2026 that may be closed by this pull request
@p-ortega
Copy link
Owner Author

Need to wait for the new nightly build

@p-ortega
Copy link
Owner Author

We are finally winning this

@p-ortega p-ortega self-assigned this Jan 29, 2026
@aufdenkampe
Copy link
Collaborator

@p-ortega, I'm glad this is finally working better! Thanks for pushing this so hard in recent weeks!!!

@p-ortega
Copy link
Owner Author

@aufdenkampe No worries at all. Also, mf6rtm is working with the latest versions of mf6 that are in the nightly build

@p-ortega p-ortega merged commit 11a99ec into develop Jan 30, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing suit for mf6api and phreeqcrm versions

3 participants