-
Notifications
You must be signed in to change notification settings - Fork 7
Improve cmdrun and testing #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Need to wait for the new nightly build |
Owner
Author
|
We are finally winning this |
p-ortega
commented
Jan 29, 2026
Collaborator
|
@p-ortega, I'm glad this is finally working better! Thanks for pushing this so hard in recent weeks!!! |
Owner
Author
|
@aufdenkampe No worries at all. Also, mf6rtm is working with the latest versions of mf6 that are in the nightly build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the project's continuous integration workflows, test infrastructure, and codebase organization. The main changes include enabling scheduled CI runs, broadening workflow triggers, adding CLI-based testing, and refactoring the CLI entrypoint for better compatibility.
Continuous Integration Improvements:
scheduletrigger in both.github/workflows/tests_main.ymland.github/workflows/tests_macos.yml. [1] [2]feature/**branches instead of justfeature/externalio. [1] [2]Testing Enhancements:
autotest/test_benchmark.pyto support running tests via the CLI by adding atest_cliflag torun_testand invoking themf6rtmCLI usingsubprocesswhen set. Thetest05benchmark now uses this new CLI-based test path. [1] [2]Codebase Cleanup and Refactoring:
__author__and__version__metadata frommf6rtm/__init__.pyfor a cleaner module interface.mf6rtm/__main__.pyto centralize CLI logic.run_cmdfunction inmf6rtm/simulation/solver.pyto accept an optionalcwdargument for improved console script compatibility and added a docstring.Optionalinmf6rtm/simulation/solver.py.