-
Notifications
You must be signed in to change notification settings - Fork 87
Add op= assignments #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add op= assignments #1359
Conversation
jafingerhut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but probably best to let one of the co-chairs do final approval and merging, rather than merging with only my approval.
vlstill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The biggest question to me is what to do with booleans. And we should be careful to specify which operators apply here, not all binary operators are usable.
a74548f to
178029a
Compare
@vlstill Are there any remaining concerns you have that have not been addressed? If so, please explain what they are, as the comments that I see appear to be addressed. |
vlstill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably just add that this is allowed for integral types (bit<N>, int<N>, int).
|
@jonathan-dilorenzo Discussed at 2025-Mar-10 LDWG meeting, and vlstill approved during the meeting. If you wish to do a final approval pass before merging, please do so, but we believe this is ready to merge into the spec. FYI, the implementation of this was merged into p4c recently. |
|
@ChrisDodd, can I ask you to add a bullet point summarizing the change to this section before I merge? |
Signed-off-by: Chris Dodd <[email protected]>
178029a to
d0b0fde
Compare
done |
Signed-off-by: Jonathan DiLorenzo <[email protected]>
For #1144