Implement self-signed certificates for HTTPS #49
Conversation
|
|
SonarCloud warning is to be expected because there are two options for running pAI-OS which are very similar: main.py from the root (eg python -m paios), which will also serve up the frontend, or a similar file in the backend folder for running API-only mode. We should however consolidate these or remove one of them. |
| <p><code>npm run build</code> in the frontend directory.</p> | ||
| <p>Or, to run a development server, use:</p> | ||
| <p><code>npm run dev</code> and connect to that instead.</p> | ||
| <p>Alternatively, you can checkout the <code><a href="https://github.com/pAI-OS/paios/tree/canary">canary</a></code> branch which includes a build.</p> |
There was a problem hiding this comment.
| <p>Alternatively, you can checkout the <code><a href="https://github.com/pAI-OS/paios/tree/canary">canary</a></code> branch which includes a build.</p> | |
| <p>Alternatively, you can checkout the <code><a href="https://github.com/pAI-OS/paios/tree/canary">canary</a></code> branch that includes a build.</p> |
There was a problem hiding this comment.
TIL something from the cloud brain who wrote it:
When choosing between “which” and “that,” the word “which” is used for non-restrictive clauses (adding extra information), while “that” is used for restrictive clauses (necessary for the sentence to make sense).
In this case, “which” is appropriate because the part about the build seems like additional information, not something crucial to identifying the “canary” branch.
My reading of it is that the first/current option gives the additional information that the canary branch includes a build, while the second option makes it mandatory, implying that you need to find one of several canary branches: the one that includes a build.
|
Thanks for the reminder to test on Windows (which I have done). |
Implemented self-signed certificate creation to enable HTTPS out of the box as Webauthn (PR #33) requires it.
We should also add support for Let's Encrypt by integrating certbot (with schedule for renewals every 60 days).