Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting conflicting rules #148

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add formatting conflicting rules #148

merged 1 commit into from
Feb 14, 2024

Conversation

paddyroddy
Copy link
Owner

No description provided.

@paddyroddy paddyroddy merged commit 5756b1a into main Feb 14, 2024
5 checks passed
@paddyroddy paddyroddy deleted the paddyroddy-patch-1 branch February 14, 2024 17:01
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Unknown

PR Summary: The pull request titled 'Add formatting conflicting rules' lacks a diff for review, making it impossible to assess the scope, impact, or quality of the proposed changes. Without any code changes or context provided in the diff, the intent and effectiveness of the PR cannot be evaluated.

Decision: Comment

📝 Type: 'Unknown' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
📝 Issue not addressed: this change does not correctly address the issue or implement the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that the PR includes a diff of the proposed changes to allow for a thorough review. A diff is essential for reviewers to understand what changes are being proposed and to provide meaningful feedback.
  • Clarify the intent and scope of the PR in the description. Given the title 'Add formatting conflicting rules', it's important to explain why these rules are being added, how they might conflict with existing rules, and the expected outcome of introducing these changes.
  • Consider providing examples or scenarios in the PR description where the new formatting rules would apply. This can help reviewers understand the practical implications and assess the changes more effectively.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant