Bump hooks #149
Bump hooks #149
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Refactoring
PR Summary: The pull request focuses on simplifying the syntax within GitHub Actions workflow files and updating the version of a pre-commit hooks repository. It includes changes such as removing unnecessary quotes around certain YAML values and updating the revision of a repository in the pre-commit configuration. These modifications aim to enhance readability and maintain the up-to-dateness of the repository's dependencies.
Decision: Comment
📝 Type: 'Refactoring' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the removal of quotes around YAML values does not affect the expected behavior, especially in contexts where special characters might be interpreted differently.
- Verify that the updated version of the pre-commit hooks repository does not introduce any breaking changes or require adjustments in the hook configurations.
- Consider providing a brief description in the PR about the testing or checks performed to ensure these changes do not introduce any regressions.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| on: | ||
| schedule: | ||
| - cron: "0 3 1 1 *" | ||
| - cron: 0 3 1 1 * |
There was a problem hiding this comment.
suggestion (llm): Removing the quotes around the cron schedule is a clean simplification. However, ensure that this does not affect the parsing of the cron syntax, especially in YAML where special characters can be interpreted differently.
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - "renovate/**" | ||
| - renovate/** |
There was a problem hiding this comment.
suggestion (llm): Unquoting the branch pattern renovate/** is a neat change for consistency. Just verify that the glob pattern works as expected in all contexts it's used.
No description provided.