Open
Conversation
Generate changelog in
|
ash211
commented
Feb 13, 2024
| void ignores_comment_on_same_line_with_no_hash() throws IOException { | ||
| Path propsFile = tempDir.resolve("versions.props"); | ||
| Files.writeString( | ||
| propsFile, "com.palantir.test:test = 1.0.0 comment on same line with no hash", StandardCharsets.UTF_8); |
Contributor
Author
There was a problem hiding this comment.
this seems less than ideal, but I'm not sure we gain much by making this invalid
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Contributor
Author
|
Still valuable but only P3 |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Expected
versions.propscomment format is not documented: https://github.com/palantir/gradle-consistent-versions?tab=readme-ov-file#versionsprops-lower-bounds-for-dependenciesAfter this PR
==COMMIT_MSG==
Document current
versions.propscomment format==COMMIT_MSG==
This also adds test coverage for the documented comment formats, plus some other comment behaviors that currently exist. I'm not sure the test case in
ignores_comment_on_same_line_with_no_hash()is ideal, but supporting that behavior doesn't seem to be hurting much.Possible downsides?
None known