Fix GcvConsumable configuration creation for Gradle 9+ compatibility#1520
Open
xJetRy wants to merge 2 commits intopalantir:developfrom
Open
Fix GcvConsumable configuration creation for Gradle 9+ compatibility#1520xJetRy wants to merge 2 commits intopalantir:developfrom
xJetRy wants to merge 2 commits intopalantir:developfrom
Conversation
Member
|
Thanks for your interest in palantir/gradle-consistent-versions, @xJetRy! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
This change addresses configuration visibility issues in Gradle 9+ by: 1. Adding `ensureBaseGcvConsumable` method that pre-creates GcvConsumable configurations during Java plugin setup, before afterEvaluate 2. Updating `recursivelyCopyProjectDependenciesWithScope` to reuse existing configurations and update their extendsFrom relationship 3. Making configurations visible in Gradle 9+ since setVisible(false) prevents variant selection discovery in newer Gradle versions The early configuration creation ensures that variant-based project dependencies can properly resolve to GcvConsumable configurations via Gradle's variant selection mechanism. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
xJetRy
force-pushed
the
fix/ensure-gcv-consumable-early-setup
branch
from
c10584a to
315d926
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureBaseGcvConsumablemethod to pre-create GcvConsumable configurations during Java plugin setuprecursivelyCopyProjectDependenciesWithScopeto reuse existing configurations and update theirextendsFromrelationshipsetVisible(false)prevents variant selection discovery in newer Gradle versionsChanges
The early configuration creation ensures that variant-based project dependencies can properly resolve to GcvConsumable configurations via Gradle's variant selection mechanism. This is necessary because:
setVisible(false)prevents configurations from being discovered by variant selection from other projectsapi(project(":foo"))) need to resolve to GcvConsumable configurations via variant selectionafterEvaluatewhen dependencies are processed