Skip to content

Excavator: Remove calls to deprecated APIs #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svc-excavator-bot wants to merge 1 commit into from
Closed

Excavator: Remove calls to deprecated APIs #1620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/test/java/com/palantir/gradle/versions/CheckUnusedConstraintIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
@AdditionallyRunWithGradle("9.3.0")
class CheckUnusedConstraintIntegrationTest {

@SuppressWarnings("for-rollout:deprecation")
@BeforeEach
void setup(RootProject rootProject) {
rootProject.buildGradle().plugins().add("java");
Expand Down
3 changes: 0 additions & 3 deletions src/test/java/com/palantir/gradle/versions/ConsistentVersionsPluginIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ void can_write_locks_using_abbreviated_write_versions_locks(GradleInvoker gradle
gradle.withArgs("resolveConfigurations").buildsSuccessfully();
}

@SuppressWarnings("for-rollout:deprecation")
@Test
@DisabledConfigurationCache("configuration cache cannot be reused due to --write-locks")
void locks_are_consistent_whether_or_not_we_do_write_locks_for_glob_forced_direct_dependency(
Expand All @@ -130,7 +129,6 @@ void locks_are_consistent_whether_or_not_we_do_write_locks_for_glob_forced_direc
gradle.withArgs("resolve").buildsSuccessfully();
}

@SuppressWarnings("for-rollout:deprecation")
@Test
@DisabledConfigurationCache(
"Cannot reference a Gradle script object from a Groovy closure as these are not supported with the"
Expand All @@ -157,7 +155,6 @@ void get_version_function_works(GradleInvoker gradle, RootProject rootProject) {
assertThat(result).output().contains("demo=1.7.25");
}

@SuppressWarnings("for-rollout:deprecation")
@Test
@DisabledConfigurationCache(
"Cannot reference a Gradle script object from a Groovy closure as these are not supported with the"
Expand Down
4 changes: 0 additions & 4 deletions src/test/java/com/palantir/gradle/versions/VersionsLockPluginIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,6 @@ implementation platform('org:platform:1.0')
""");
}

@SuppressWarnings("for-rollout:deprecation")
@Test
void verifylocks_is_cacheable(GradleInvoker gradle, RootProject rootProject) {
rootProject.buildGradle().plugins().add("java");
Expand All @@ -375,7 +374,6 @@ void verifylocks_is_cacheable(GradleInvoker gradle, RootProject rootProject) {
.upToDate();
}

@SuppressWarnings("for-rollout:deprecation")
@Test
void verifylocks_current_lock_state_does_not_get_poisoned_by_existing_lock_file(
GradleInvoker gradle, RootProject rootProject) {
Expand Down Expand Up @@ -593,7 +591,6 @@ void constraints_on_production_do_not_affect_scope_of_test_only_dependencies(
""");
}

@SuppressWarnings("for-rollout:deprecation")
@Test
void published_constraints_are_derived_from_lock_file_with_local_constraints(
GradleInvoker gradle, RootProject rootProject, SubProject foo, SubProject bar) throws IOException {
Expand Down Expand Up @@ -792,7 +789,6 @@ private void verifyLockfile(GradleProject project, String... lines) {

@Nested
class MultiSubprojectWithConflictingVersions {
@SuppressWarnings("for-rollout:deprecation")
@BeforeEach
void setup(RootProject rootProject, SubProject foo, SubProject bar, SubProject forced) {
foo.buildGradle().plugins().add("java");
Expand Down
5 changes: 0 additions & 5 deletions src/test/java/com/palantir/gradle/versions/VersionsPropsPluginIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ void setup(MavenRepo repo, RootProject rootProject) {
""", repo.path());
}

@SuppressWarnings("for-rollout:deprecation")
@Test
void star_dependency_constraint_is_injected_for_direct_dependency(
GradleInvoker gradle, RootProject rootProject, SubProject foo) {
Expand All @@ -123,7 +122,6 @@ void star_dependency_constraint_is_injected_for_direct_dependency(
verifyLockfile(foo, "org.slf4j:slf4j-api:1.7.24");
}

@SuppressWarnings("for-rollout:deprecation")
@Test
void star_dependency_constraint_is_not_forcefully_downgraded_for_transitive_dependency(
GradleInvoker gradle, RootProject rootProject, SubProject foo) {
Expand All @@ -146,7 +144,6 @@ void star_dependency_constraint_is_not_forcefully_downgraded_for_transitive_depe
verifyLockfile(foo, "org.slf4j:slf4j-api:1.7.22");
}

@SuppressWarnings("for-rollout:deprecation")
@Test
void star_dependency_constraint_upgrades_transitive_dependency(
GradleInvoker gradle, RootProject rootProject, SubProject foo) {
Expand All @@ -169,7 +166,6 @@ void star_dependency_constraint_upgrades_transitive_dependency(
verifyLockfile(foo, "org.slf4j:slf4j-api:1.7.25");
}

@SuppressWarnings("for-rollout:deprecation")
@Test
void imported_platform_generated_correctly_in_pom(GradleInvoker gradle, RootProject rootProject, SubProject foo)
throws IOException {
Expand Down Expand Up @@ -221,7 +217,6 @@ rootConfiguration platform('org:platform')
assertThat(actualDependencies).containsExactlyInAnyOrderElementsOf(expectedDependencies);
}

@SuppressWarnings("for-rollout:deprecation")
@Test
void non_glob_module_forces_do_not_get_added_to_a_matching_platform_too(
GradleInvoker gradle, RootProject rootProject) {
Expand Down