Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeSpec initializer comment support #113

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Scottmitch
Copy link

Motivation:
When generating code it maybe useful to insert
comments as anchors for post processing and further extension by other code generation tools. However this is not easy to achieve with the existing API.

Modifications:

Add a TypeSpec.addInitializerComment method which is emitted only as comments above the addInitializerBlock.

Motivation:
When generating code it maybe useful to insert
comments as anchors for post processing and further extension by other code generation tools. However
this is not easy to achieve with the existing API.

Modifications:

Add a TypeSpec.addInitializerComment method which is emitted only as comments above the addInitializerBlock.
@palantirtech
Copy link
Member

Thanks for your interest in palantir/javapoet, @Scottmitch! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Nov 5, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

TypeSpec initializer comment support

Check the box to generate changelog(s)

  • Generate changelog entry

@Scottmitch
Copy link
Author

Moved from square/javapoet#967.

Still interested in this feature, can someone advise on merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants