feature: Add adapters/svc1zap for code that accepts *zap.Logger#198
Merged
bulldozer-bot[bot] merged 5 commits intodevelopfrom Apr 22, 2022
Merged
feature: Add adapters/svc1zap for code that accepts *zap.Logger#198bulldozer-bot[bot] merged 5 commits intodevelopfrom
bulldozer-bot[bot] merged 5 commits intodevelopfrom
Conversation
tabboud
requested changes
Apr 22, 2022
Contributor
tabboud
left a comment
tabboud
left a comment
There was a problem hiding this comment.
Overall looks good to me. Just a few nits
Co-authored-by: Tony Abboud <tdabboud@hotmail.com>
Contributor
Author
|
@tabboud done! |
tabboud
approved these changes
Apr 22, 2022
Collaborator
|
Released 1.20.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar in inspiration to long-stalled #114. In some products that use witchcraft logging, we depend on packages that use zap. This adapter lets us create a zap logger which delegates to svc1log for emitting SLS-valid payloads.
Examples of open-source libraries which accept zap outputs but we want logs emitted as service.1:
==COMMIT_MSG==
Add
adapters/svc1zapfor code that accepts*zap.Logger==COMMIT_MSG==
This change is