This repository was archived by the owner on Feb 22, 2024. It is now read-only.
make the default jwt_payload_handler work even if the identity has no 'id' attribute #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as #63 |
Author
|
Closing this because of being a duplicate of #63. |
|
Hello, I just ran into the same issue, please merge :) Regards, Adam. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation of
jwt_payload_handlerfails if theidentityobject has noidattribute, even though it was clearly an intention to fall back to a dictionary lookup when such an attribute does not exist. The current implementation fails becausegetattrthrows anAttributeErrorfor missing attributes if no default value is provided. The patch fixes this by providing a default value ofNonefor the attribute lookup, preventing the exception.