This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
core: fix default for UNAUTHORIZED_VIEW #726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirikuncar
force-pushed
the
724-default-value
branch
from
df8de7f
to
c0111d4
Compare
jirikuncar
force-pushed
the
724-default-value
branch
from
c0111d4
to
a9ca553
Compare
* Changes default to `None` to be consistent with documentation. (closes pallets-eco#724)
jirikuncar
force-pushed
the
724-default-value
branch
2 times, most recently
from
3a25287
to
05ff114
Compare
|
ping @jonafato or @mattupstate Can you please review? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noneto be consistent with documentation.(closes
SECURITY_UNAUTHORIZED_VIEWdoesn't default toNone#724)--
cc @sunqingyao
(closes #677)