This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Fix documentation for #781 #791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirikuncar
approved these changes
Oct 10, 2018
|
The plaintext passwords should still be possible: https://github.com/mattupstate/flask-security/blob/89198288bc416a7921b4973d8e897993942bb428/flask_security/utils.py#L455 |
jasco
pushed a commit
to jasco/flask-security
that referenced
this pull request
Oct 3, 2023
* Update test_common.py Added testcase for failing toke-authentication on session-only endpoint * Update conftest.py Added session-only authenticated route to test-fixture * Update decorators.py Added the `_check_session` function to specifically check session data to be used as authentication_method in the `auth_required` * Update decorators.py * Update decorators.py * fixed decorator and added tests * Fix session-only authentication. If an endpoint was decorated with "session" only - a properly submitted token would also be accepted. Fix that by checking as part of the auth_required() decorator and the user is authenticated AND was authenticated using the _user_loader (which is what flask-login calls for session based authenticated). close pallets-eco#791 --------- Co-authored-by: N247S <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the documentation. But, on the same topic, currently the extension doesn't really support plaintext anymore, and I guess it's not encouraged per se:
https://github.com/mattupstate/flask-security/blob/89198288bc416a7921b4973d8e897993942bb428/flask_security/utils.py#L120-L127
So why not eliminate it completely? Additionally, the transparent update of plaintext passwords to the configured hash is also something arguable (backward compatibility?)