-
Notifications
You must be signed in to change notification settings - Fork 9
Security workflow #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
You have successfully added a new templateanalyzer configuration |
param applicationInsightsName string = '' | ||
param appServicePlanId string | ||
param keyVaultName string = '' | ||
param managedIdentity bool = !empty(keyVaultName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't make that change in azure-dev yet, raised a discussion
param scmDoBuildDuringDeployment bool = false | ||
param use32BitWorkerProcess bool = false | ||
param ftpsState string = 'FtpsOnly' | ||
param healthCheckPath string = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is from upstream
param containerAppsEnvironmentName string | ||
param containerName string = 'main' | ||
param containerRegistryName string = '' | ||
param containerRegistryName string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PR
param logAnalyticsWorkspaceName string = '' | ||
param containerAppsEnvironmentName string | ||
param containerRegistryName string | ||
param logAnalyticsWorkspaceName string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PR
keyVaultName: keyVaultName | ||
kind: kind | ||
linuxFxVersion: linuxFxVersion | ||
managedIdentity: managedIdentity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to my own change to appservice.bicep
param name string = 'add' | ||
|
||
param keyVaultName string = '' | ||
param keyVaultName string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PR
linuxFxVersion: linuxFxVersion | ||
alwaysOn: alwaysOn | ||
ftpsState: ftpsState | ||
minTlsVersion: '1.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In upstream already
minimumElasticInstanceCount: minimumElasticInstanceCount != -1 ? minimumElasticInstanceCount : null | ||
use32BitWorkerProcess: use32BitWorkerProcess | ||
functionAppScaleLimit: functionAppScaleLimit != -1 ? functionAppScaleLimit : null | ||
healthCheckPath: healthCheckPath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In upstream
} | ||
|
||
identity: { type: managedIdentity ? 'SystemAssigned' : 'None' } | ||
identity: { type: 'SystemAssigned' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undecided managedIdentity change
} | ||
|
||
output identityPrincipalId string = managedIdentity ? appService.identity.principalId : '' | ||
output identityPrincipalId string = appService.identity.principalId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undecided managedIdentity change
Pending suggestions for how to fix functions.bicep: |
No description provided.