feat: prevent permit2.permit frontrun #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefSnoopy
approved these changes
Sep 13, 2024
ChefMist
added a commit
that referenced
this pull request
Sep 13, 2024
* feat: updated pancake-v4-periphery * feat: update test cases based on latest v4-periphery * feat: updated v4-periphery * feat: update code based on latest commit * chore: clean up commented code * feat: #8 return early * feat: add missing early return for 1 command * chore: forge-test after merge * feat: prevent permit2.permit frontrun (#14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
This PR port the same fix on v4-periphery on universal router
ref fix on periphery: pancakeswap/pancake-v4-periphery@e9876ae#diff-ddeb661b27108ab4906ab13bc6580108952c80a33170dfae362c33085b3c333d
On universal router front,
PERMIT2_PERMITandPERMIT2_PERMIT_BATCHcommand will supportALLOW_REVERT(can see test), so if permit2 was front-run, other following commands can still execute