fix: Series.dt argument 'ambiguous' can be boolean#1178
Merged
Dr-Irv merged 3 commits intopandas-dev:mainfrom Apr 3, 2025
Merged
Conversation
26ac79e to
a75cde3
Compare
Collaborator
|
Thanks for the PR. The CI is failing because |
bb23906 to
59c92b7
Compare
Dr-Irv
requested changes
Apr 3, 2025
Collaborator
Dr-Irv
left a comment
There was a problem hiding this comment.
Instead of doing the __all__ thing, can you just pin pyright to 1.1.397 in pyproject.toml, because I just reported an issue here in pyright : microsoft/pyright#10248
Collaborator
|
Also, can you not "force push" so then I can see what is changed with each commit more easily? |
59c92b7 to
585c942
Compare
Contributor
Author
|
Hi @Dr-Irv , thank you for the review and input. I force-pushed because I wanted to keep the commits clean. |
Dr-Irv
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
In the documentation and in practice, Series.dt.floor, Series.dt.round and Series.dt.ceil accept the argument
ambiguousas boolean, which is however not supported inpandas-stubs.To Reproduce
Provide a minimal runnable
pandasexample that is not properly checked by the stubs.Indicate which type checker you are using (
mypyorpyright).mypyShow the error message received from that type checker while checking your example.
Please complete the following information:
OS: [e.g. Windows, Linux, MacOS]
Microsoft Windows 10 Enterprise
OS Version [e.g. 22]
10.0.19045 N/A Build 19045
python version
Python 3.13.2
version of type checker
mypy==1.15.0version of installed
pandas-stubspandas-stubs==2.2.3.250308Additional context
Add any other context about the problem here.