Fix #1334: Update DataFrame.from_records signature and add tests #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Aug 20, 2025
…ange np.ndarray to np_2d_array for data parameter- Change SequenceNotStr[str] to ListLike for columns and exclude parameters- Add test case with pd.Index as columns parameterAddresses review feedback from Dr-Irv
iclectic
changed the title
iclectic
changed the title
iclectic
changed the title
iclectic
changed the title
iclectic
changed the title
iclectic
force-pushed
the
development
branch
2 times, most recently
from
e6c054f to
44fd08e
Compare
… use Sequence[SequenceNotStr] | Sequence[Mapping[str, Scalar]] | Mapping[str, Sequence[Scalar]]- Update columns and exclude parameters to use ListLike | None = None- Update index parameter to use SequenceNotStr for better type precisionAddresses review feedback from Dr-Irv on issue pandas-dev#1334
… np_2darray support to data parameter type annotation- Add comprehensive tests for DataFrame.from_records in test_frame.py- Fix NumPy 2.0 compatibility in test (S1 instead of a1)- Test covers np.ndarray, list of tuples, pd.Index columns, and structured arrays- Addresses GitHub issue pandas-dev#1334
Dr-Irv
requested changes
Aug 21, 2025
There was a problem hiding this comment.
Be sure to test locally. Set up your environment as shown here:
https://github.com/pandas-dev/pandas-stubs/blob/main/docs/setup.md
Then do poe test to make sure the tests pass locally.
- Update data parameter types to accept Sequence[Mapping[str, Any]] and Mapping[str, SequenceNotStr[Any]] - Add comprehensive tests for np.ndarray, tuples, and mapping inputs - Address GitHub issue pandas-dev#1334 per Dr-Irv feedback - All 207 DataFrame tests pass with no issues
Dr-Irv
requested changes
Aug 21, 2025
…-dev#1334 The main changes include: - Updated data parameter types from overly restrictive Scalar to more flexible Any types - Added .reshape(2, 2) to numpy array test to handle CI compatibility issues across different numpy versions - Included a test for mapping of sequences using DataFrame constructor (which seems to be the right approach for that data type) All 207 DataFrame tests still pass
Dr-Irv
requested changes
Aug 22, 2025
…-dev#1334 Addresses Dr-Irv's feedback: - Updated data parameter types from restrictive Scalar to flexible Any - Added .reshape(2, 2) to numpy test for CI compatibility - Added proper dictionary tests (list and single) without tuple conversion - Added Mapping[str, Any] type support for single dictionaries - Used DataFrame constructor for mapping sequences test All tests pass.
Dr-Irv
requested changes
Aug 23, 2025
… values - Change index parameter type from SequenceNotStr[str] to SequenceNotStr[Hashable] - Apply black formatting to test files - Resolves CI type checking issues per Dr-Irv feedback This allows index parameter to accept integers and other hashable values, not just strings, matching pandas runtime behavior.
Dr-Irv
requested changes
Aug 25, 2025
…mapping dict test. Applied black formatting and pre-commit fixes
Dr-Irv
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.from_records()needs better annotations #1334This PR adds a test for
DataFrame.from_records()with tuple data to validate type annotations work correctly. The test ensures the method properly returns a DataFrame when called with a list of tuples and column names, addressing the type checking issues raised in the original issue.