Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test Github Actions Arm64 Runners #60722

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lithomas1 lithomas1 added the Build Library building on various platforms label Jan 16, 2025
@lithomas1
Copy link
Member Author

Looks like we're too early :(

some issues with micromamba it seems.

timeout-minutes: 90
strategy:
matrix:
platform: [ubuntu-22.04, ubuntu-24.04-arm]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the job name: and concurrency group: will need to account for matrix.platform now

@mroeschke
Copy link
Member

some issues with micromamba it seems.

Might be worth raising an issue in https://github.com/mamba-org/setup-micromamba/?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lithomas1
Copy link
Member Author

issue could be actions/partner-runner-images#25?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lithomas1 lithomas1 marked this pull request as ready for review January 18, 2025 17:31

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lithomas1
Copy link
Member Author

This should be mostly working (failures don't seem like my fault?)

@mroeschke mroeschke added this to the 3.0 milestone Jan 21, 2025
@mroeschke mroeschke merged commit b983366 into pandas-dev:main Jan 21, 2025
101 of 106 checks passed
@mroeschke
Copy link
Member

Thanks @lithomas1. We're on our way to removing the CircleCI builds!

@lithomas1 lithomas1 deleted the gha-arm64-ci branch January 21, 2025 19:22
@lithomas1 lithomas1 modified the milestones: 3.0, 2.3 Jan 21, 2025
@lithomas1
Copy link
Member Author

@meeseeksdev backport 2.3.x

Copy link

lumberbot-app bot commented Jan 21, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b98336653128790661d4c66d398f3e44d481dd3b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60722: CI: Test Github Actions Arm64 Runners'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60722-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60722 on branch 2.3.x (CI: Test Github Actions Arm64 Runners)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lithomas1
Copy link
Member Author

Let's backport this - I think I was having issues with build versioning last release on the Circle jobs.

Consolidating under GHA should provide better observability/debugability into failures in general.

@jorisvandenbossche
Copy link
Member

Only backporting the wheel change could be sufficient then?

@lithomas1
Copy link
Member Author

Only backporting the wheel change could be sufficient then?

Yes, but the GHA jobs have better coverage so we might as well backport that too.

jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Jan 24, 2025
* CI: Test Github Actions Arm64 Runners

* try using platform as cache key

* fixes

* add platform for includes jobs

(cherry picked from commit b983366)
@jorisvandenbossche
Copy link
Member

Manual backport -> #60780

jorisvandenbossche added a commit that referenced this pull request Jan 24, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
(cherry picked from commit b983366)

Co-authored-by: Thomas Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants