-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
TST: add test for dtype
argument in str.decode
#61872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
pandas/tests/strings/test_strings.py
Outdated
def test_decode_with_dtype_none(): | ||
# Ensure that future.infer_string is enabled | ||
set_option("future.infer_string", True) | ||
ser = Series([b"a", b"b", b"c"]) # Use byte strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ser = Series([b"a", b"b", b"c"]) # Use byte strings | |
ser = Series([b"a", b"b", b"c"]) |
pandas/tests/strings/test_strings.py
Outdated
|
||
def test_decode_with_dtype_none(): | ||
# Ensure that future.infer_string is enabled | ||
set_option("future.infer_string", True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the option_context
context manager
def test_decode_with_dtype_none(): | ||
# Ensure that future.infer_string is enabled | ||
with option_context("future.infer_string", True): | ||
ser = Series([b"a", b"b", b"c"]) # Use byte strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ser = Series([b"a", b"b", b"c"]) # Use byte strings | |
ser = Series([b"a", b"b", b"c"]) |
Co-authored-by: Matthew Roeschke <[email protected]>
This PR adds a test case for
str.decode
and ensures it correctly infers the string datatype, whendtype=None
and the optionfuture.infer_string
is used. This argument was introduced in PR #60940 but has no test for None. This test adds coverage to the following line:Note: Parts of this test have been automatically generated by a novel technique that we're currently developing as part of an academic research project aiming at improving test coverage. To not waste developer time, two researchers manually checked the test before submitting it. We appreciate the developers' time and any feedback is welcomed.