Skip to content

Output formatting: preserve quoting for string categories #61891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jorisvandenbossche
Copy link
Member

POC for #61890 if we want to keep the quoting behaviour

@simonjayhawkins simonjayhawkins added Output-Formatting __repr__ of pandas objects, to_string Categorical Categorical Data Type Strings String extension data type and string data labels Jul 22, 2025
@jorisvandenbossche jorisvandenbossche marked this pull request as ready for review July 23, 2025 21:12
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this for 2.3.2 or 3.0?

@jorisvandenbossche jorisvandenbossche added this to the 2.3.2 milestone Jul 24, 2025
@jorisvandenbossche
Copy link
Member Author

It's an easy change, so let's add to 2.3.x (I might just not backport all test fixes)

@jorisvandenbossche jorisvandenbossche merged commit c849d39 into pandas-dev:main Jul 25, 2025
43 checks passed
@jorisvandenbossche jorisvandenbossche deleted the string-dtype-categorical-repr branch July 25, 2025 13:26
Copy link

lumberbot-app bot commented Jul 25, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 c849d39c4c956495c0c86b85ab561bf74bf5df8d
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #61891: Output formatting: preserve quoting for string categories'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-61891-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #61891 on branch 2.3.x (Output formatting: preserve quoting for string categories)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Output-Formatting __repr__ of pandas objects, to_string Still Needs Manual Backport Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants