BUG: validate to_offset aliases before stride parsing#65587
Open
sun-0-set wants to merge 3 commits into
Open
Conversation
Member
|
cc @natmokval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md.When parsing fractional strides with an invalid non-tick alias,
to_offsetattempts to parse the stride as an integer before validating the alias, exposing a lower-levelinvalid literal for int()error for inputs like"2.5foo", which obfuscates the actual error (invalid alias).This runs
offset=_get_offset()early to validate non-tick offset names before going into stride parsing.Note: This is not elegant in the least, but imo does the job. A broader fix would entail rethinking the validation and error reporting logic for invalid and deprecated aliases/suffixes.
Validation:
python -m pytest pandas/tests/tslibs/test_to_offset.py -q