Closed
Conversation
pangea-andrest
force-pushed
the
PAN-20205-base-url-template
branch
from
e0eb0f1 to
5119165
Compare
Contributor
|
Is there any way for the caller to also set the header they wish to pass? Specifically I need to be able to set a Host header, when using the SDK inside of PUC and making internal cluster calls |
cj-f
reviewed
Mar 25, 2025
| """Holds run time configuration information used by SDK components.""" | ||
|
|
||
| domain: str = "aws.us.pangea.cloud" | ||
| base_url_template: str = "https://{SERVICE_NAME}.aws.us.pangea.cloud/" |
Contributor
There was a problem hiding this comment.
It feels unnecessarily risky to me to have this be a breaking change, couldn't Config object allow for either domain or base_url_template keyword parameter, and then this can be added instead of replacing?
Member
|
Superseded by #674. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.