Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

and Pantherflow query type #580

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Draft

and Pantherflow query type #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions panther_analysis_tool/detection_schemas/analysis_config_schema.json
View file
Original file line number Diff line number Diff line change
@@ -1546,6 +1546,9 @@
"Query": {
"type": "string"
},
"PantherFlowQuery": {
"type": "string"
},
"QueryName": {
"type": "string"
},
2 changes: 1 addition & 1 deletion panther_analysis_tool/schemas.py
View file
Original file line number Diff line number Diff line change
@@ -262,7 +262,7 @@ def validate(
{
"AnalysisType": Or("saved_query"),
"QueryName": And(str, NAME_ID_VALIDATION_REGEX),
Or("Query", "AthenaQuery", "SnowflakeQuery"): str,
Or("Query", "AthenaQuery", "SnowflakeQuery", "PantherFlowQuery"): str,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@debugmiller does it make sense to also add this to the SCHEDULED_QUERY_SCHEMA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can't be scheduled so I don't think so?

Optional("Description"): str,
Optional("Tags"): [str],
Optional("Lookback"): bool,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Lookback override | where p_event_time > time.ago(1d)?

9 changes: 9 additions & 0 deletions tests/unit/panther_analysis_tool/test_schemas.py
View file
Original file line number Diff line number Diff line change
@@ -337,6 +337,15 @@ def test_saved_query_validate_schema(self):
"Query": "select 1",
}
)

# allows PantherFlow
SAVED_QUERY_SCHEMA.validate(
{
"QueryName": "my.query.id",
"AnalysisType": "saved_query",
"PantherFlowQuery": "// test",
}
)
# missing QueryName
with self.assertRaises(SchemaError):
SAVED_QUERY_SCHEMA.validate(