Fixes #156 - Deprecate "shout" event #488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xprazak2
force-pushed
the
deprecate-shout
branch
from
cca3fa0 to
95e27c5
Compare
Author
|
I think the removal can be done in 3 steps:
|
xprazak2
force-pushed
the
deprecate-shout
branch
from
95e27c5 to
c37afad
Compare
reichert621
requested changes
Dec 23, 2020
Collaborator
reichert621
left a comment
reichert621
left a comment
There was a problem hiding this comment.
just one small nitpick, and could we also handle this in the notification_channel as well?
thanks!
| # It is also common to receive messages from the client and | ||
| # broadcast to everyone in the current topic (conversation:lobby). | ||
| def handle_in("shout", payload, socket) do | ||
| defp handle_in_msg(event_name, payload, socket) do |
Collaborator
There was a problem hiding this comment.
nitpick -- can we name this something like handle_incoming_message instead? i think it's a bit more explicit :)
also let's move this to the bottom with the other private methods so we can fix the warning below 👍
Author
There was a problem hiding this comment.
I renamed the method and moved it to the bottom - naming is hard ;-)
I also made similar changes in notification_channel.
xprazak2
force-pushed
the
deprecate-shout
branch
4 times, most recently
from
351569b to
2bfd0f6
Compare
reichert621
requested changes
Jan 3, 2021
| assert_push("shout", _msg) | ||
| end | ||
|
|
||
| test "message:created broadcasts to notification:lobby", %{ |
Collaborator
There was a problem hiding this comment.
looks like this test is failing?
xprazak2
force-pushed
the
deprecate-shout
branch
from
2bfd0f6 to
a45dda8
Compare
Deprecate "shout" event for conversation channel in favor of "message:created".
xprazak2
force-pushed
the
deprecate-shout
branch
from
a45dda8 to
f20e3c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate "shout" event for conversation channel
in favor of "message:created".
Issue
#156