-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: auto-generate translation strings #9462
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## dev #9462 +/- ##
========================================
Coverage 97.77% 97.77%
========================================
Files 508 508
Lines 21767 21767
Branches 1821 1697 -124
========================================
Hits 21283 21283
- Misses 482 484 +2
+ Partials 2 0 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see you picking this up after our conversation in b0390a9.
Oh I hadn’t thought about the notification to translators. Are they annoying?
Well, if they are constantly send because just a single string got adjusted, or several ones a day because various changes get merged.
Yes, I would not be too happy about it and I would prefer to be informed of a relevant amount of changes to look into or before a release for example.
But again, not exactly sure how the CrowdIn service is handling this.
on: | ||
push: | ||
branches: | ||
- dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be handy to trigger the workflow manually on demand without the need of a push to dev
branch:
on: | |
push: | |
branches: | |
- dev | |
on: | |
push: | |
branches: | |
- dev | |
workflow_dispatch: |
Proposed change
Would be good to leave these off of the PRs, make the PRs cleaner. Downside, I suppose is if they somehow cause an error, but that seems rare.
This commits directly to dev, could be changed to open a PR of course.
Edit: Added PAT because of https://github.com/marketplace/actions/git-auto-commit#push-to-protected-branches
Example run: https://github.com/paperless-ngx/paperless-ngx/actions/runs/14016242452 which generated: a2a19fb
Closes #(issue or discussion)
Type of change
Checklist:
pre-commit
hooks, see documentation.