Fix parsing html with tag that has 'tag' attribute #311
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurelie-vndl
added a commit
to weconnectdata/php-html-parser
that referenced
this pull request
Mar 29, 2023
mr-chetan
added a commit
to devanoxltd/php-html-parser
that referenced
this pull request
Aug 24, 2025
Replaces direct tag property access with getTag() method in the Parser class to improve encapsulation and consistency when checking for 'script' tags. https: //github.com/paquettg/pull/311 Co-Authored-By: Vladyslav Shut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing html with tag that has 'tag' attribute.
Now it you will try to parse html like
<html><body tag="body"></body></html>it fails.